OpenXRay/xray-16

Bug in _types.h

Open

#195 opened on Apr 21, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (519 forks)auto 404
Code QualityHelp wanted

Repository metrics

Stars
 (3,524 stars)
PR merge metrics
 (PR metrics pending)

Description

https://github.com/OpenXRay/xray-16/blob/70f130c6fc719293c3b6abb1ccacbb084eaee6d1/src/xrCore/_types.h#L31 Is there problem with determination min values here ? For example -std::numeric_limits::max() != std::numeric_limits::min() also for signed types. http://en.cppreference.com/w/cpp/types/numeric_limits Also can replace type_zero to std::numeric_limits::lowest() ?

Contributor guide

Research direction
Examine the types.h file, specifically line 31, to understand the current usage of std::numeric limits. Check if the min values for signed types are incorrectly defined using std::numeric limits<int>::max() instead of std::numeric limits<int>::min(). Consider replacing type zero with std::numeric limits<int>::lowest() for signed types. Consult the cppreference documentation for std::numeric limits to confirm the correct usage.
Tech stack
cpp
Domain
game dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65