OpenVoiceOS/ovos-lingua-franca

ambiguous contractions

Open

#20 opened on Mar 25, 2022

 (1 comment) (0 reactions) (3 assignees)Python (5 forks)auto 404
bugenhancementhelp wanted

Repository metrics

Stars
 (6 stars)
PR merge metrics
 (PR metrics pending)

Description

the following unit tests have a TODO, we don't have anything concrete planned to solve this and should start discussing it

       # TODO: Ambiguous with "he had"
       self.assertEqual(normalize("he'd"), "he would"
       # TODO: Ambiguous with "he has"
        self.assertEqual(normalize("he's"), "he is")
        # TODO: Ambiguous with "how would"
        self.assertEqual(normalize("how'd"), "how did")
        # TODO: Ambiguous with "how has" and "how does"
        self.assertEqual(normalize("how's"), "how is")
        # TODO: Ambiguous with "I had"
        self.assertEqual(normalize("I'd"), "I would")
        # TODO: Ambiguous with "it has"
        self.assertEqual(normalize("it's"), "it is")
         # TODO: Ambiguous wiht "she had"
        self.assertEqual(normalize("she'd"), "she would")
        # TODO: Ambiguous with "someone had"
        self.assertEqual(normalize("someone'd"), "someone would")
        # TODO: Ambiguous with "someone has"
        self.assertEqual(normalize("someone's"), "someone is")
        # TODO: Ambiguous with "that has"
        self.assertEqual(normalize("that's"), "that is")
        # TODO: Ambiguous with "that had"
        self.assertEqual(normalize("that'd"), "that would")
        # TODO: Ambiguous with "there had"
        self.assertEqual(normalize("there'd"), "there would")
         # TODO: Ambiguous with "there has"
        self.assertEqual(normalize("there's"), "there is")
        # TODO: Ambiguous with "they had"
        self.assertEqual(normalize("they'd"), "they would")
          # TODO: Ambiguous wiht "we had"
        self.assertEqual(normalize("we'd"), "we would")
        # TODO: Ambiguous with "what has" / "what does")
        self.assertEqual(normalize("whats"), "what is")
         # TODO: Ambiguous with "when has"
        self.assertEqual(normalize("when's"), "when is")
        # TODO: Ambiguous with "where has" / where does"
        self.assertEqual(normalize("where's"), "where is")
          # TODO: Ambiguous with "who had" "who did")
        self.assertEqual(normalize("who'd"), "who would")
        # TODO: Ambiguous with "who has" / "who does"
        self.assertEqual(normalize("who's"), "who is")
        # TODO: Ambiguous with "why has" / "why does"
        self.assertEqual(normalize("why's"), "why is")
         # TODO: Ambiguous with "you had"
        self.assertEqual(normalize("you'd"), "you would")
         # TODO: "everyone's" is also the possessive of "everyone"
        self.assertEqual(normalize("everyone's"), "everyone is")

related PR https://github.com/OpenVoiceOS/ovos-lingua-franca/pull/6

Contributor guide