[RelDB] Use or delete table_alias in SqlQueryHelper.build_filter_str

Open Beginner friendly
#3,430 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Quiet
Tech stack
python, sql
Domain
databases

Research direction

Locate SqlQueryHelper.build_filter_str and its sole caller, then inspect how table_alias is handled in the method. Confirm whether the alias branch is unreachable and resolve the variable's use or removal consistently. Run the relevant backend tests to verify filter SQL generation remains correct.

Written by the indexing model from the issue text.

Description

SqlQueryHelper.build_filter_str is called outside of this method only once, without table_alias. Check if table_alias: is always false and the code for this case is not reachable. The variable table_alias should be either used or deleted.

Dominant language
Python
Stars
9
Forks
40
Avg merge
1d 22h
Merged PRs (30d)
19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from OpenSlides/openslides-backend

All issues in OpenSlides/openslides-backend

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.