OpenKore/openkore

Itemlink (ITEML) for 2020 clients

Open

#3,541 opened on Nov 19, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Perl (1,200 forks)batch import
feature requesthelp wanted

Repository metrics

Stars
 (1,467 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

  • Openkore version git: ec5091eefefb40e984224382c58a4957753c8507
  • Server: Local test, rAthena, serverType kRO_RagexeRE_2020_04_01b
  • Bug Report / Feature Request: Feature Request
  • Summary:

Follow up the sub solveItemLink since #2541, on 2020 client (or idk since when exactly), the message pattern was changed for the separators as

older clients

  • card: (
  • options:
    • id: *
    • param: +
    • val: ,

2020+ client

  • card: )
  • options
    • id: +
    • param: ,
    • val: -

I don't know how to place or better implementation to support those differences.

Contributor guide

Research direction
Inspect the existing sub solveItemLink and implement conditional parsing based on server version or packet pattern.
Tech stack
None
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
PerlGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50