OpenKore/openkore

Confusing language used when deleting characters

Open

#128 opened on Jun 30, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Perl (1,467 stars) (1,200 forks)batch import
code cleaningenhancementhelp wantedpriority: low

Description

In the current character delete code, there is a lot of broken english and prompts that don't necessarilly make sense. For example, when a character is marked for deletion it says "your character is lefting [timestamp]" as in... "your character won't be deleted until [timestamp]"? At least that's what I think it means...

Also when you are prompted to confirm the deletion, you are asked for a birthday / security code, however, when you actually submit the information, it says the email you entered is incorrect.

Contributor guide

Tech stack
None
Domain
desktoplocalization
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PerlText editing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
Examine the character deletion module in the OpenKore source code, specifically the user facing prompts. Fix the broken English phrases like 'your character is lefting' and ensure consistent grammar. Verify that the deletion confirmation prompt correctly references the user's email rather than an incorrect field. Refer to comments on the issue for any additional context.