Sync: changing name may cause problems

Open
#1,544 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
52/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
typescript
Domain
tooling

Research direction

No file or test is named. Start by locating the logic that generates step IDs from names, then reproduce a deploy after renaming a step while retaining its existing ID. Done means an existing local step ID is preserved and the deployment diff no longer changes that ID unexpectedly; add or run the relevant regression coverage.

Written by the indexing model from the issue text.

Description

Need to come back and test this later

I think I've changed a step name in a local project file. Then tried to deploy. And I've been given a super wierd diff in which step ids have changed.

There's some logic to generate a step id from a name. We need to check that we only do this if a step id isn't already present. Obviously the id will never get sent to lightning, but it seems OK to keep the local state.

Dominant language
TypeScript
Stars
21
Forks
23
Avg merge
1d 22h
Merged PRs (30d)
17

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from OpenFn/kit

All issues in OpenFn/kit

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.