OpenFeign/feign

Allow for 3xx range headers

Open

#249 opened on Jul 12, 2015

View on GitHub
 (28 comments) (0 reactions) (0 assignees)Java (9,070 stars) (1,911 forks)batch import
documentationhelp wanted

Description

Everything above 299 is considered an error, which is plainly incorrect.

To get around this I had to:

  1. add an error decoder
  2. throw a special exception for 3xx range
  3. when catching runtime errors, check if it is the special 300 error
  4. convert to a valid response entity

Will investigate replacing this line:

if (response.status() >= 200 && response.status() < 300) { in SynchronousMethodHandler and PR'ing it. I just wonder why nobody else has come across this issue.

Should I fix it?

Contributor guide

Tech stack
java
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaHTTP basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue is about Feign treating all HTTP status codes above 299 as errors, which incorrectly includes 3xx redirects. The fix involves modifying a single line in SynchronousMethodHandler.java (likely line checking `response.status() >= 200 && response.status() < 300`). After making the change, ensure existing tests pass and add a test for redirect handling. The issue has extensive discussion but no assignee or PR, so it is open for contribution.