OpenFeign/feign

Feign observation span is not put in "scope" - loggers do not see current spanId

Closed

#2,406 opened on May 5, 2024

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Java (1,911 forks)batch import
bughelp wanted

Repository metrics

Stars
 (9,070 stars)
PR merge metrics
 (Avg merge 2d 17h) (71 merged PRs in 30d)

Description

Despite new observation is started around feign call, MDC still contains "parent" spanId.

Code to reproduce:

https://github.com/norbson/feign-tracing-issue

run and call http://localhost:8080/test

Result: Screenshot from 2024-05-05 18-04-03

Contributor guide

Research direction
The issue is that the Feign observation span is not placed in scope, causing MDC to retain the parent spanId. Investigate the Feign observation instrumentation, likely in the `feign micrometer` module. Check if the observation is being opened and closed correctly, and ensure that the span is set as the current span in the tracing context. Look at the Micrometer Observation API's `Observation.Scope` usage and compare with similar tracing integrations. The reproduction repository is at https://github.com/norbson/feign tracing issue.
Tech stack
javaspring
Domain
backendapiobservability
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaSpringMicrometer Observation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50