OpenFeign/feign

feign-kotlin: dismiss404 doesn't work in CoroutineFeign

Closed

#2026 opened on Apr 26, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (9,070 stars) (1,911 forks)batch import
bughelp wanted

Description

Hi! CoroutineBuilder does not set dismiss404 property so it is initialized with false when AsyncFeign is being created. Is this intended?

Contributor guide

Tech stack
javakotlin
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaKotlinFeign basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The issue is that CoroutineBuilder in CoroutineFeign.java (line 160-181) does not propagate the dismiss404 property to AsyncFeign. To fix, locate CoroutineBuilder and ensure that the dismiss404 field is set on the AsyncFeign.Builder before building. Refer to how other properties like logLevel are passed. Also check existing tests for CoroutineFeign to add a test for this scenario.