OpenFeign/feign

Enhance SoapDecoder by using Content Type from Response as Mime Type

Open

#1,732 opened on Aug 25, 2022

View on GitHub
 (2 comments) (1 reaction) (0 assignees)Java (9,070 stars) (1,911 forks)batch import
help wantedproposal

Description

By sending a soap request to an external service, i've found that the response of that soap call contains the Content-Type "multipart/related; type="application/xop+xml"; boundary=...".

The result is that the soap Message unmarshalling fails with some error "Unexpected content...". I've fixed that by creating a copy of SoapDecoder and propagate the Content-Type of the response to the MessageFactory. After that the Soap Envelope was unmarshalled as expected.

The relevant part that i've changed is:

final MimeHeaders mimeHeaders = new MimeHeaders();
final String contentType = response.headers().get("Content-Type").stream().collect(Collectors.joining(";"));
mimeHeaders.setHeader("Content-Type", contentType);
SOAPMessage message = MessageFactory.newInstance(soapProtocol)
                                    .createMessage(mimeHeaders, response.body().asInputStream());

Would be nice if it's possible to always use the Content-Type from the Response, but i don't know if there are any other pitfalls when doing that in general.

Kind regards,

Stefan

Contributor guide

Tech stack
java
Domain
api
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaSOAPFeign framework
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue is to modify SoapDecoder to use the Content Type header from the HTTP response as the MIME type when creating the SOAPMessage. The user provided a code snippet showing the change in the decoder. Look at the SoapDecoder class in the Feign repository (likely `core/src/main/java/feign/soap/SoapDecoder.java`). The fix involves reading the 'Content Type' header from the response and setting it on the MimeHeaders before creating the message. Ensure that this change does not break other use cases where the content type might be missing or different. The maintainers may need to discuss the general applicability and potential pitfalls.
Enhance SoapDecoder by using Content Type from Response as Mime Type · OpenFeign/feign#1732 | Good First Issue