OpenFeign/feign

ErrorDecoder not invoked when Apache Http client throws checked exception

Open

#1,487 opened on Aug 17, 2021

View on GitHub
 (8 comments) (0 reactions) (1 assignee)Java (9,070 stars) (1,911 forks)batch import
buggood first issuehelp wanted

Description

Hi, I have discovered issue when using feign.httpclient.ApacheHttpClient. In some cases Apache client throws ProtocolException which is a checked exception. This happens for example when server returned 303 HTTP code but there was no location header. In such case Feign proxy throws UndeclaredThrowableException instead of invoking ErrorDecoder.

Contributor guide

Tech stack
java
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaFeignApache HttpClient
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the ApacheHttpClient class in the feign httpclient module to understand how it currently handles checked exceptions like ProtocolException. The issue likely requires modifying the exception handling to ensure that such exceptions are caught and passed to the ErrorDecoder. Look for any comments or linked PRs from the assignee for additional context. Test with a scenario where a server returns 303 without a Location header to reproduce the problem.
ErrorDecoder not invoked when Apache Http client throws checked exception · OpenFeign/feign#1487 | Good First Issue