OpenFeign/feign

RetryableException requires Request

Open

#1,296 opened on Oct 27, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (9,070 stars) (1,911 forks)batch import
help wantedproposal

Description

The constructors for RetryableException were updated in #1039 to require the original Request object. In some cases the Request may contain sensitive information and never be used from the RetryableException, so it would be nice to have an option to create one without the Request to limit surface area.

Additionally, FeignException already exposes a hasRequest() method, so clients would be able to check whether RetryableException has a Request before attempting to access it.

I'd be more than happy to open a PR if this sounds like a reasonable use case. Thanks!

Contributor guide

Tech stack
java
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaFeign library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the RetryableException class in the source code to understand current constructors. Review the changes from PR #1039 that made Request required. Consider adding a new constructor that does not take Request, or making Request optional. Also check FeignException's hasRequest() method to ensure consistency. Create a PR with the changes and update tests accordingly.
RetryableException requires Request · OpenFeign/feign#1296 | Good First Issue