OpenFeign/feign

Can't set Content-type for Request Header when use Spring annotations

Open

#1,239 opened on Jun 10, 2020

View on GitHub
 (9 comments) (5 reactions) (0 assignees)Java (9,070 stars) (1,911 forks)batch import
bughelp wantedneeds info

Description

I'm using Feign and Spring annotations, I have a request that expects to accept "text/plain".

@PostMapping(value = "/demo", consumes = "application/json", produces="text/plain")
public String demo(@RequestBody List<Long> ids);

But, the produces value not working. The request still has a header: Accept=application/json

Contributor guide

Tech stack
java
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaFeignSpring
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Look at the Feign Spring contract implementation in the `feign spring4` or `spring` module. The issue is about the `produces` attribute not setting the Accept header. Investigate how the `RequestTemplate` is built from the method annotation. Check if there is a missing mapping for `produces` to the Accept header. Consider comparing with how `consumes` is handled. The fix likely involves adding the Accept header from the `produces` value.