[BUG] [C] _convertToJSON returns NULL if field is numeric and has value 0
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
Research direction
Start in modules/openapi-generator/src/main/resources/C-libcurl/model-body.mustache at line 425 and inspect how numeric fields are handled in _convertToJSON. Reproduce the reported behavior with a numeric field whose value is 0, then verify that generated C code no longer returns NULL for that valid value.
Written by the indexing model from the issue text.
Description
Description
The C generator accidentally treats a numeric field like a pointer
in _convertToJSON and returns NULL whenever that field has value 0.
This applies to all numeric fields (dobue, int) with value 0
when _convertToJSON is called.
openapi-generator version
7.15.0
Suggest a fix
In modules/openapi-generator/src/main/resources/C-libcurl/model-body.mustache
at line 425 we have
{{^isEnum}}
if (!{{{classname}}}->{{{name}}}) {
goto fail;
}
{{/isEnum}}
This is likely wrong and should be something like:
{{^isEnum}}
{{^isNumeric}}
if (!{{{classname}}}->{{{name}}}) {
goto fail;
}
{{/isNumeric}}
{{/isEnum}}
simply because failing when a numeric value is 0 is plain wrong.
- Dominant language
- Java
- Stars
- 26.8k
- Forks
- 7.7k
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 103
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from OpenAPITools/openapi-generator
-
Issue: Bug
Difficulty 1/5 Under an hour Newbie friendliness 91/100
OpenAPITools/openapi-generator#24978 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
OpenAPITools/openapi-generator#24975 ·
-
Issue: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
OpenAPITools/openapi-generator#24859 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
OpenAPITools/openapi-generator#24852 · 1 comment ·
-
[BUG][KOTLIN] Fails to compile after updating to 7.25.0 with useJackson3=false useSpringBoot4=true OpenIssue: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
OpenAPITools/openapi-generator#24842 · 1 comment ·
All issues in OpenAPITools/openapi-generator
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
infinispan/infinispan#18150 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
opensearch-project/k-NN#3597 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100