OpenAPITools/openapi-generator

[REQ][php] declareStrictTypes option for all PHP generators

Open

#12,771 opened on Jul 5, 2022

View on GitHub
 (2 comments) (4 reactions) (0 assignees)Java (7,516 forks)batch import
Client: PHPEnhancement: FeatureGood First IssueServer: PHP

Repository metrics

Stars
 (26,243 stars)
PR merge metrics
 (Avg merge 9d 1h) (123 merged PRs in 30d)

Description

Is your feature request related to a problem? Please describe.

Usually I totally against codegen options which modifies one line of code, but this one looks really handy.

Describe the solution you'd like

Add declareStrictTypes switch option to AbstractPhpCodegen class, then:

openapi-generator-cli generate -g php --additional-properties=declareStrictTypes=true \
    -o out -i petstore.yaml

then in all mustache files:

<?php 

{{#declareStrictTypes}}declare(strict_types=1);{{/declareStrictTypes}}

We also need to decide whether this switch option should be on or off by default. I think it should be on, but it can cause breaking changes.

Describe alternatives you've considered

Close this issue as not necessary feature 😆

Additional context

cc @jebentier @dkarlovi @mandrean @jfastnacht @renepardon

Contributor guide

Research direction
Implement the declareStrictTypes option in AbstractPhpCodegen class and update PHP mustache templates to conditionally include the declare(strict types=1) statement. Consider default value and potential breaking changes.
Tech stack
javaphp
Domain
toolingbackend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaPHPGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80