OneKeyHQ/app-monorepo

Consider using react-native-quick-crypto

Open

#1,680 opened on Oct 6, 2022

View on GitHub
 (4 comments) (2 reactions) (0 assignees)TypeScript (2,363 stars) (513 forks)user submission
enhancementfeature requestgood first issue

Description

Hey!

I noticed this repo uses react-native-crypto, which itself uses crypto-browserify under the hood. crypto-browserify is a JS-based implementation for crypto, which is slower than Margelo's react-native-quick-crypto, since that uses C++ (OpenSSL) with JSI under the hood.

If you want to replace react-native-crypto with the faster react-native-quick-crypto, I'm happy to help out or answer questions! 😄

Contributor guide

Tech stack
typescriptreact native
Domain
mobileperformance
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with React NativeBasic understanding of native modulesKnowledge of crypto APIs
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
First, review the current usage of react native crypto in the codebase to understand where and how crypto functions are called. Then, compare the API of react native quick crypto with the existing library to ensure compatibility. Check for any breaking changes or different method signatures. Finally, plan a step by step replacement, test on both iOS and Android, and measure performance improvements.