OfflineIMAP/offlineimap

Include exit code of pre/post sync hooks when exiting?

Open

#517 opened on Jan 15, 2018

View on GitHub
 (2 comments) (2 reactions) (0 assignees)Python (1,765 stars) (373 forks)batch import
enhancementgood first issueneed contributor!

Description

General informations

  • system/distribution (with version): Red Hat Enterprise Linux Server release 7.4 (Maipo)
  • offlineimap version (offlineimap -V): offlineimap v7.1.4, imaplib2 v2.57 (bundled), Python v2.7.5, OpenSSL 1.0.1e-fips 11 Feb 2013
  • Python version: Python 2.7.5
  • server name or domain:
  • CLI options: timeout --foreground --signal=QUIT 4m
    /path/to/offlineimap.git/offlineimap.py
    -c /path/to/offlineimaprc

Steps to reproduce the error

No error as such, but I was wondering if there was some way for offlineimap to allow the exit code of presynchook or postsynchook to be returned by offlineimap itself? For example, I use a postsynchook which I've just noticed in my syslog is misbehaving, and exiting with error 127. However, offlineimap exists with zero indicating that everything is ok. Am I able to somehow make offlineimap include the exit value of the postsynchook when generating it's exit code upon exit? Or does the exit code of the pre/postsync hooks need to be managed separately (eg send result to a file for testing after offlineimap has exited)? Thanks! Matt (happy offlineimap user for many years)

Contributor guide

Tech stack
python
Domain
cli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Pythonofflineimap hook mechanismexit code handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the offlineimap source to locate where hooks are invoked and exit codes are collected. The main script likely contains the exit path. Also, review the offlineimap3 successor for any existing exit code handling. Since this repository is legacy, contributing to offlineimap3 may be more appropriate. Check issue comments for any prior discussion or maintainer input.
Include exit code of pre/post sync hooks when exiting? · OfflineIMAP/offlineimap#517 | Good First Issue