OWASP/NodeGoat

Migration to bcrypt

Open

#158 opened on Aug 6, 2019

View on GitHub
 (14 comments) (0 reactions) (0 assignees)HTML (1,794 stars) (1,526 forks)batch import
Good first issuehelp wantedjspriority: MEDIUMtask

Description

Context

  • This is part of release-1.5 #148
  • MEDIUM priority task

Tasks

  • Remove dependency bcrypt-nodejs in package.json
  • Add dependency bcrypt in package.json
  • Migrate file app/data/user-dao.js to bcrypt
  • Validate the instalation with the local test
  • Add and submit the changes in package-lock.json
  • Add the primary dependency list to the readme.md
  • Check that the npm tasks are working as expected
  • Update the readme.md with the extra relevant info (if needed)

Assignation

  • This tasks is open for assignation, just claim it (as reply to this) and submit your PR ;-)

Important

Contributor guide

Tech stack
javascriptnodejs
Domain
backendsecurity
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.js basicsnpm package managementGit and GitHub workflow
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Review the current usage of bcrypt nodejs in app/data/user dao.js to understand the API differences. Then install the bcrypt package and update the file to use bcrypt's hash and compare methods. Update package.json, package lock.json, and readme.md accordingly. Test the changes by running npm test.