ORNL/GridKit

Set pmech and efd in Genrou hard_coded_residual

Open

#271 opened on Oct 14, 2025

View on GitHub
 (2 comments) (0 reactions) (1 assignee)C++ (10 forks)auto 404
buggood first issuetesting

Repository metrics

Stars
 (23 stars)
PR merge metrics
 (PR metrics pending)

Description

In the Genrou hard_coded_residual test, since we are not calling gen.initialize() and there are no control devices, pmech_set_ and efd_set_ are never initialized. They default to 0 in most situations I have tested, but this is not guaranteed. I've been experimenting with another way of handling those set points that led to an undefined behavior. Initializing those values to 0 where they are declared makes the test pass, but I doubt that's the behavior we want.

https://github.com/ORNL/GridKit/blob/bcca730dd74a99d5c1416fa1065199b751bed2fe/tests/UnitTests/PhasorDynamics/GenrouTests.hpp#L163

Also see the discussion in #266 for the case where signal nodes are used.

cc @joshua-x-7 @abirchfield @pelesh

Contributor guide

Research direction
Examine the Genrou class constructor and the test file at the referenced line to determine where pmech set and efd set should be initialized to ensure defined behavior. Also review discussion in #266 for signal node cases.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60