NuGet/Home

Browsing through the source code - possible bug in PackageUtilities?

Open

#9,724 opened on Jun 27, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)HTML (292 forks)batch import
Area:ErrorHandlingCategory:Quality WeekFunctionality:SDKPriority:2Type:Buggood first issuehacktoberfesthelp wanted

Repository metrics

Stars
 (1,459 stars)
PR merge metrics
 (Avg merge 464d 23h) (1 merged PR in 30d)

Description

Hello, shouldn't be the FatalProtocolException thrown when nuspecStream == null instead of nupkgStream == null?

PackageUtilities.cs

image

Contributor guide

Research direction
Examine the null check at line 26 of PackageUtilities.cs and confirm whether the exception should be thrown when nuspecStream is null instead of nupkgStream.
Tech stack
csharp
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90