NuGet/Home

Multiple warnings on push are improperly formatted

Open

#8,001 opened on Apr 14, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)HTML (1,459 stars) (292 forks)batch import
Functionality:PushPriority:2Type:Buggood first issuehelp wanted

Description

I used dotnet.exe v2.2.202 to push a package that has no license with an API key that expires in a day. The output was:

info : Pushing dotnet-develop.0.0.0-prerelease.nupkg to 'https://www.nuget.org/api/v2/package'...
info :   PUT https://www.nuget.org/api/v2/package/
warn : Your API key expires in 1 days. Visit https://www.nuget.org/account/apikeys to regenerate your API key.,All published packages should have license information specified. Learn more: https://aka.ms/deprecateLicenseUrl.
info :   Created https://www.nuget.org/api/v2/package/ 652ms
info : Your package was pushed.

Notice that the warning on line 3 has two messages joined by a period and a comma, but no spaces. The client should properly format warning messages returned by the server.

Contributor guide

Tech stack
csharp
Domain
clideveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C# basicsNuGet client codebase familiarity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Investigate the NuGet.Client repository, specifically the code that handles server response warnings during package push. Look for string concatenation logic that joins warning messages. A candidate file is within the NuGet.CommandLine or NuGet.Commands namespace. Search for where warnings are parsed from the HTTP response and formatted for console output.