NuGet/Home

nuget.exe pack with both -symbols and -suffix give incorrect name to symbol package

Open

#3,530 opened on Sep 26, 2016

View on GitHub
 (6 comments) (2 reactions) (0 assignees)HTML (1,459 stars) (292 forks)batch import
Functionality:PackPriority:2Type:Bughelp wanted

Description

Steps

  1. Create a .nuspec on disk.
  2. Make sure there are some files to pack (nuget.exe pack won't make an empty package).
  3. Run nuget.exe pack path\to\my.nuspec -symbols -suffix beta

Expected

Two nupkgs, one ending in beta.nupkg and the other ending in beta.symbols.nupkg.

Actual

The symbols package's file name has the version number without the suffix. The .nuspec inside the package seems fine though.

Example

nuget.exe pack VS.Redist.NuGet_VS15.nuspec -symbols -suffix BETA

Attempting to build package from 'VS.Redist.NuGet_VS15.nuspec'.
Successfully created package 'C:\Users\jver\Desktop\foo\VS.Redist.NuGet_VS15.3.5.160923.1438-BETA.nupkg'.
Successfully created package 'C:\Users\jver\Desktop\foo\VS.Redist.NuGet_VS15.3.5.160923.1438-bar.symbols.nupkg'.

Tried on latest dev and 3.5.0-rc1.

Contributor guide

Tech stack
csharpshell
Domain
clitooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of NuGet packagingFamiliarity with C#Understanding of command line tools
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the NuGet client code, specifically the packaging logic in NuGet.CommandLine or NuGet.Packaging. Look for how the symbols and suffix flags are combined when generating the output filename. The bug report indicates that the version suffix is omitted from the symbols package filename. Check the method that constructs the package file name, likely in the PackCommand or related classes. Consider checking the test suite for existing pack tests.
nuget.exe pack with both -symbols and -suffix give incorrect name to symbol package · NuGet/Home#3530 | Good First Issue