NuGet/Home

PackTask should embed the .nuspec file in the binlog

Open

#13,128 opened on Jan 4, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)HTML (1,459 stars) (292 forks)batch import
Area:LoggingFunctionality:PackPriority:2Type:Featurehelp wanted

Description

PackTask should probably add the .nuspec path to the EmbedInBinlog item so that the (generated) .nuspec file gets embedded in the binlog. It'd be useful to see what the final nuspec file looked like that was used to pack.

Contributor guide

Tech stack
csharp
Domain
build system
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C#MSBuildNuGet packaging
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue requests adding the .nuspec file path to the EmbedInBinlog item in PackTask. Look at how other tasks (e.g., in the Microsoft.NET.Sdk) use EmbedInBinlog to embed files into the binary log. Find the PackTask implementation in the NuGet client repository (likely in src/NuGet.Core). Then add the .nuspec path (probably generated during pack) to the EmbedInBinlog item group. There are no existing PRs or comments that provide additional guidance.
PackTask should embed the .nuspec file in the binlog · NuGet/Home#13128 | Good First Issue