NuGet/Home

Refactor UIActionEngineTests that use packagesFolder to avoid looking at the drive root

Open

#12,556 opened on Apr 24, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)HTML (1,459 stars) (292 forks)batch import
Category:Quality WeekFunctionality:VisualStudioUIPriority:2Type:Testgood first issue

Description

@"\packagesFolder" seems like a bad idea. A single leading '' usually means "from the root of the drive" on Windows. A temporary directory or a local directory (@".\packgesFolder") seems better.

https://github.com/NuGet/NuGet.Client/pull/5109/files#r1175482193

Contributor guide

Tech stack
csharp
Domain
testing
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C# basicsunit testingNuGet client tests
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The issue is to refactor UIActionEngineTests that use a hardcoded path '\packagesFolder' to a temporary directory, as suggested in PR #5109. Look at the test file UIActionEngineTests (likely in the NuGet.Client repo) and replace occurrences of @"\packagesFolder" with a path like Path.Combine(Path.GetTempPath(), "packagesFolder") or use a test temp directory. Ensure the change is consistent with similar test patterns.