NuGet/Home

``nuget.exe push *.nupkg`` doesn't push more than one file

Open

#10,217 opened on Nov 2, 2020

View on GitHub
 (0 comments) (3 reactions) (0 assignees)HTML (292 forks)batch import
Functionality:PushPriority:2Product:NuGet.exeType:Bughelp wanted

Repository metrics

Stars
 (1,459 stars)
PR merge metrics
 (Avg merge 464d 23h) (1 merged PR in 30d)

Description

The nuget.exe counterpart to https://github.com/NuGet/Home/issues/4393 where the dotnet.exe experience was fixed, but we didn't want to break nuget.exe outside of a major release.

https://github.com/NuGet/NuGet.Client/pull/3739#issuecomment-720481177

It turns out though, that extending push command for nuget.exe is rather not possible due to problems with backwards compatibility. There is some special ApiKey logic, which for cases where ApiKey is not specified, it assumes that second parameter is an ApiKey (https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Clients/NuGet.CommandLine/Commands/PushCommand.cs#L51-L58) This behaviour is also documented here https://docs.microsoft.com/en-gb/nuget/reference/cli-reference/cli-ref-push#examples.

Contributor guide

Research direction
Examine the PushCommand.cs file to understand how it currently handles multiple file arguments, focusing on the ApiKey logic that prevents wildcard pushes.
Tech stack
csharp
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70