Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Follow logic is backwards

Open
#130 1 comment 0 reactions 1 assignee View on GitHub

@julianlam is already working on this.

Since Jul 14, 2020.

Assessment

This issue has not been assessed yet.

Description

bug

For rewriting when this API is merged into core...

Follow's API is of the format /api/v2/users/:uid/follow where :uid is the person to follow, and _uid (or the uid from the non-master key) is the person whose edit list we are editing.

  • This does not follow the convention of assuming that :uid is always referring to the subject.
  • This also does not allow for situations where an admin with a non-master token wants to edit a user's follow list (the API will always only allow them to edit their own list

The API should be: /api/v2/users/:uid/follow/:targetUid where:

  • _uid is the calling user (for permissions checking and so on)
  • uid is the user whose follow list you are editing
  • targetUid is the user you are (un)following
Dominant language
JavaScript
Stars
136
Forks
75
Avg merge
1m
Merged PRs (30d)
8

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from NodeBB/nodebb-plugin-write-api

All issues in NodeBB/nodebb-plugin-write-api

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.