cue: ldflags version injection is now a no-op

Open Beginner friendly
#496,528 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Quiet
Domain
build-system

Research direction

Start from the nixpkgs package definition for cue and inspect where its -ldflags version injection is configured. Remove that obsolete argument and verify that the package still builds and that cue version reports the expected version from the git tag.

Written by the indexing model from the issue text.

Description

We have been stamping versions into cue binaries from VCS since v0.15.0; see https://github.com/Homebrew/homebrew-core/pull/270529 for example.

It seems like you already build from a git tag, so cue version should already work correctly. You can remove the -ldflags version injection, as it no longer does anything.

Dominant language
Nix
Stars
26.2k
Forks
20.1k
Avg merge
14h 6m
Merged PRs (30d)
584

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from NixOS/nixpkgs

All issues in NixOS/nixpkgs

Similar issues

More Build System issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.