NixOS/nix

Switch to std::format

Open

#10,294 opened on Mar 22, 2024

View on GitHub
 (4 comments) (8 reactions) (0 assignees)C++ (1,293 forks)batch import
good first issue

Repository metrics

Stars
 (9,803 stars)
PR merge metrics
 (Avg merge 7d 11h) (83 merged PRs in 30d)

Description

Is your feature request related to a problem? Please describe.

Unlike boost::format, std::format is supposed to check format strings at compile time, so it should prevent problems like #10293 once and for all.

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

Priorities

Add :+1: to issues you find important.

Contributor guide

Research direction
Identify all occurrences of boost::format in the Nix source code and replace them with equivalent std::format calls, paying attention to format specifiers and compile time checking. Ensure backward compatibility and consider any differences in error handling.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50