NineFX/bs-precis

Errors in Precis Implementation

Open

#3 opened on Jul 23, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Reason (0 forks)auto 404
bughelp wantedpriority

Repository metrics

Stars
 (1 star)
PR merge metrics
 (PR metrics pending)

Description

Currently we generate tests off of @byllyfish/precis_i18n including their original golden.json. The additional 40,000 tests were added to golden.json. We are missing around 2.5% of the comparisons. At the very least, it would be very helpful to know why, if not patch those issues.

Test Suites: 2 failed, 2 passed, 4 total
Tests:       1025 failed, 42276 passed, 43301 total
Snapshots:   0 total
Time:        101.394s

Contributor guide

Research direction
Compare the failing test outputs with the expected golden values in golden.json to identify missing comparisons and understand which conditions are not being handled.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70