FreeDNS certbot plugin back to version 0.1.0
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 65/100
Research direction
Start with backend/certbot/dns-plugins.json and compare its FreeDNS entry with the linked pull request. Reproduce the FreeDNS certificate flow using the Docker image and inspect the logs; done means the ttl-related error is gone and certificate issuance succeeds for a free subscriber.
Written by the indexing model from the issue text.
Description
Checklist
- Have you pulled and found the error with
jc21/nginx-proxy-manager:latestdocker image?- Yes
- Are you sure you're not using someone else's docker image?
- Yes
- Have you searched for similar issues (both open and closed)?
- Yes
Describe the bug
In the backend/certbot/dns-plugins.json, the version is set 0.1.0, which causes problems as it's looking for a ttl field that is not provided for free subscribers.
A patch had been provided about a year ago (https://github.com/NginxProxyManager/nginx-proxy-manager/pull/3750/files#diff-460b85a8109d0faeea45e159d9577439a89ee230186a4c525bdec4dd589c1040) to set the version to 0.2.0 - but apparently it was reverted somehow in the latest NPM version.
Nginx Proxy Manager Version
2.14.0
To Reproduce
Try to add a certificate for a FreeDNS subdomain name; the interface provides a not so helpful "Internal error" message. The logs reveal
File "/opt/certbot/lib/python3.11/site-packages/certbot_dns_freedns/dns_freedns.py", line 286, in _load_txt_record input_ttl = soup.find("input", recursive=True, attrs={"name": "ttl"}).get("value") ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'NoneType' object has no attribute 'get'
Expected behavior
No error should be present; it used to work in December last year - unfortunately, I can't remember which version of NPM I was using.
- Dominant language
- TypeScript
- Stars
- 34.2k
- Forks
- 3.9k
- Avg merge
- 22h 6m
- Merged PRs (30d)
- 22
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from NginxProxyManager/nginx-proxy-manager
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
NginxProxyManager/nginx-proxy-manager#5856 · 3 reactions ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
NginxProxyManager/nginx-proxy-manager#5753 · 1 reaction ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
NginxProxyManager/nginx-proxy-manager#5748 · 2 comments ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
All issues in NginxProxyManager/nginx-proxy-manager
Similar issues
-
calcite-components needs triage refactor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Esri/calcite-design-system#15203 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 91/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100