Netflix/security_monkey

What does the Change Emails "With Issues" option mean under notification settings?

Open

#945 opened on Feb 15, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (4,341 stars) (832 forks)batch import
bughelp wanted

Description

Under notification settings, I set Change Emails to be "With Issues" and set EMAIL_AUDIT_REPORTS_INCLUDE_JUSTIFIED=False in the config. I assumed this meant it would only email me on changes with unjustified issues, however I still get emails for changes that have no issues at all (e.g. creating / deleting RDS snapshots, updating route 53 records, etc.). Is this a bug or am I not understanding what "With issues" means? Also, I am using the code in the develop branch fetched 2-14.

Thanks!

Contributor guide

Tech stack
pythonaws
Domain
securitybackend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic PythonSecurity Monkey notification settings
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the notification settings logic in the Security Monkey codebase, particularly around the 'With Issues' option and the EMAIL AUDIT REPORTS INCLUDE JUSTIFIED configuration. Look at the source files for email notifications (e.g., `security monkey/notification utils.py` or similar) to understand the condition used to filter changes. Check the two comments on the issue for any additional details or hints. Identify whether the logic correctly excludes changes without issues or if there is a bug that sends emails for all changes regardless.