Netflix/security_monkey

What does the Change Emails "With Issues" option mean under notification settings?

Open

#945 opened on Feb 15, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (832 forks)batch import
bughelp wanted

Repository metrics

Stars
 (4,341 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Under notification settings, I set Change Emails to be "With Issues" and set EMAIL_AUDIT_REPORTS_INCLUDE_JUSTIFIED=False in the config. I assumed this meant it would only email me on changes with unjustified issues, however I still get emails for changes that have no issues at all (e.g. creating / deleting RDS snapshots, updating route 53 records, etc.). Is this a bug or am I not understanding what "With issues" means? Also, I am using the code in the develop branch fetched 2-14.

Thanks!

Contributor guide

Research direction
Examine the notification filtering code in the Security Monkey codebase, focusing on how the 'With Issues' option and EMAIL AUDIT REPORTS INCLUDE JUSTIFIED setting interact. Reproduce the issue by creating changes with and without issues and checking if the notification is sent only when deserved.
Tech stack
python
Domain
backendcloudsecurity
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75