Neptune-Crypto/neptune-core

Catch Potential Error when Trying to Find Wallet Database

Open

#559 opened on Apr 21, 2025

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (45 forks)auto 404
good first issuehelp wantedminor

Repository metrics

Stars
 (110 stars)
PR merge metrics
 (PR metrics pending)

Description

See #556.

In WalletState::new_from_context:

        let database_is_new = !tokio::fs::try_exists(&data_dir.wallet_database_dir_path()).await.unwrap();

What if the path cannot be verified to exist or not exist? try_exists will return an Err case and the unwrap() will cause a panic. Let's catch that case gracefully.

I think it's preferable to catch this edge case and log a warning message. "Cannot determine existence of wallet database." Or something like that. And the variable database_is_new should be set to false so as to avoid unnecessary work.

I realize that down the line things will probably fail when the client tries to read data from the wallet database but

a) by the time control flow gets there the problem may have been resolved
b) a future refactor might find a way around that problem without affecting scan mode policy.

Contributor guide

Research direction
Replace the unwrap() on the try exists result with match or if let to handle the error, log a warning, and set database is new to false.
Tech stack
rust
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70