NekR/offline-plugin

Make `offline-plugin` work with webpack-dev-server

Open

#138 opened on Nov 29, 2016

View on GitHub
 (5 comments) (7 reactions) (0 assignees)JavaScript (4,506 stars) (319 forks)batch import
PR-welcomeenhancementhelp wanted

Description

This includes live reload and Hot Module Replacement. In those cases offline-plugin's cache functions should do nothing, i.e. not handle fetch event.

Reasons: someone may want to test push notifications / background sync in dev mode with webpack-dev-server.

(Probably even reload SW file's code when it changes)

Contributor guide

Tech stack
javascript
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Webpack knowledgeService Worker basicswebpack dev serveroffline plugin usage
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate how offline plugin currently registers the service worker and intercepts fetch events. Look at the source code (likely src/index.js) to conditionally skip fetch handling when webpack dev server is detected. Check how other plugins handle HMR compatibility. Refer to any linked PRs or discussions in the issue comments for potential approaches.