NaturalIntelligence/imglab

Delete key not working on Mac

Open

#152 opened on Apr 26, 2019

View on GitHub
 (14 comments) (0 reactions) (0 assignees)HTML (930 stars) (560 forks)batch import
bugfirst-timers-onlygood first issuehelp wanted

Description

Describe the bug I am not able to delete a wrong annotation in Mac using Chrome.

To Reproduce Steps to reproduce the behavior:

  1. Go to imglab.ml/#. Open an image
  2. Click on Polygon. Try to make an annotation. And then try to delete it.
  3. It fails

Screenshots

Even after pressing delete key multiple times, it is not working.

Console Errors

None

Device detail (please complete the following information):

  • OS: [e.g. Ubuntu] Mac
  • Browser [e.g. chrome, firefox] Chrome

Additional context

Watch for changes, or Bookmark for easy discovery. Fund this project for new features and maintenance. [Showcase] your project with us by raising an issue

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontendtooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptHTML/CSSevent handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the keydown event listeners for the annotation area. On Mac, the Delete key may have a different key code. Look for code that handles keyboard shortcuts for deleting annotations, likely in JavaScript files. Check for browser specific handling and consider using event.key instead of event.keyCode. Test the fix on Chrome on Mac.