[@nativescript/biometrics] Android `promptForPin` method checks options for `pinFallBack` instead of `pinFallback`

Open Beginner friendly
#640 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
android, typescript
Domain
authentication, mobile

Research direction

Start at packages/biometrics/index.android.ts around line 426 and inspect the promptForPin() options check. Correct the inconsistent fallback property name, then verify that promptForPin() recognizes the documented pinFallback option without requiring the misspelled variant.

Written by the indexing model from the issue text.

Description

While debugging, we found that in the promptForPin() method in the android code for biometrics, it's checking for the wrong property.

https://github.com/NativeScript/plugins/blob/a503c40264e6704cbf87ccaaa76da5b8486b4e46/packages/biometrics/index.android.ts#L426

if (!options?.pinFallBack) {

should be

if (!options?.pinFallback) {

NOTE: We can fix it by passing both pinFallBack and pinFallback through on the options, but it would be best if this were fixed.

Dominant language
TypeScript
Stars
206
Forks
123
Avg merge
2d 1h
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from NativeScript/plugins

All issues in NativeScript/plugins

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.