NativeScript/nativescript-camera

Pictures are saved to file system but never deleted

Open

#74 opened on Nov 15, 2017

View on GitHubContributor guide
 (9 comments) (0 reactions) (0 assignees)TypeScript (46 forks)auto 404
featuregood first issuehelp wanted

Repository metrics

Stars
 (94 stars)
PR merge metrics
 (PR metrics pending)

Description

I had a problem with my app, where for every picture taken, the storage consumption would grow of about 5 MB, on Android 7.0 (Samsung J5). Tried debugging, to see if I made a mistake or something, and found out that every picture you take is saved in a folder (path specified with this line) picturePath = utils.ad.getApplicationContext().getExternalFilesDir(null).getAbsolutePath() + "/" + "NSIMG_" + dateStamp + ".jpg";

Wouldn't it be better if the plugin did either:

  1. Remove the file after consumption
  2. Have a "filepath" property in the options, in order to write the file directly to the folder you need it to be.

As of now I'm removing the file as soon as I get the ImageSource from ImageAsset.

Contributor guide

Research direction
Investigate the plugin code to find where the picture file is saved and used (e.g., when ImageSource is created). Ensure the temporary file is deleted after the image is consumed. Alternatively, implement a configurable file path option so the user can specify where to save the file, avoiding unnecessary copies.
Tech stack
typescript
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65