Expost remove listeners for firebase messaging
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 42/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- firebase, typescript
- Domain
- mobile
Research direction
Start by locating the messaging implementations for onMessage and onNotificationTap, then inspect how each listener is registered and retained. The work is done when both APIs provide a way to remove their listeners, comparable to the authentication listener example, and the existing messaging behavior remains intact.
Written by the indexing model from the issue text.
Description
When listening to onMessage, onNotificationTap there is no way to remove listeners and is leading to memory leak
// on message
firebase()
.messaging()
.onMessage(async (remoteMessage) => {
console.log({ remoteMessage });
});
// on notification tap
firebase()
.messaging()
.onNotificationTap((message) => {
console.log({ message });
});
there is no way to remove listeners as there is for firebase auth
firebase().auth().addAuthStateChangeListener
firebase().auth().removeAuthStateChangeListener
- Dominant language
- TypeScript
- Stars
- 62
- Forks
- 53
- Avg merge
- 8d 4h
- Merged PRs (30d)
- 2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from NativeScript/firebase
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
NativeScript/firebase#292 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
NativeScript/firebase#289 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
NativeScript/firebase#288 · 4 reactions ·
-
bug ios
NativeScript/firebase#287 · 1 assignee ·
-
Uh-Oh Shazam Open
Difficulty 4/5 3-5 days Newbie friendliness 20/100
NativeScript/firebase#286 ·
All issues in NativeScript/firebase
Similar issues
-
VerificationGate: ATTRIBUTION quote guard never matches a normal quotation (\b around the quote) Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
danielmiessler/LifeOS#2234 ·
-
T: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
Mend: dependency security vulnerability untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 70/100