Modal route issue - route runs twice when returning from second modal containing route outlet
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- angular, typescript
- Domain
- frontend, mobile-dev
Research direction
Start with the NSRouteReuseStrategy.shouldDetach method and compare it with the earlier implementation in commit beb cde23c4d6a392638c23ec1e2bc63b06a9b43e. Reproduce the numbered flow in the linked StackBlitz demo on iOS, including returning from the second modal containing a route outlet. Done means the step-five back navigation runs its animation once rather than backwards and forwards.
Written by the indexing model from the issue text.
Description
This is most evident in iOS. I've set up a demo app:
https://stackblitz.com/edit/nativescript-stackblitz-templates-vwcmqt
In iOS, if you follow the steps (they're numbered) you'll see that when you navigate back on step five, the animation runs twice—backwards then forwards. This appears to come from the shouldDetach method NSRouteReuseStrategy. If I use the previous code for shouldDetatch that was altered here:
https://github.com/NativeScript/angular/commit/bebcde23c4d6a392638c23ec1e2bc63b06a9b43e
then it works without problem.
NOTE: For this demo, I've used 14.2.6-alpha.0 because without it, I can't use modals with ModalDialogParams because of injector scope issues. However, this router problem described above also occurs in 14.2.5 when the modal corrections are in place. Either way, something isn't working as it should.
- Dominant language
- TypeScript
- Stars
- 55
- Forks
- 13
- Avg merge
- 16m
- Merged PRs (30d)
- 1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from NativeScript/angular
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
NativeScript/angular#170 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
NativeScript/angular#164 ·
-
My types are gone Open
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
NativeScript/angular#163 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
NativeScript/angular#158 · 1 reaction ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
NativeScript/angular#155 ·
All issues in NativeScript/angular
Similar issues
-
clawsweeper:linked-pr-open clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:message-loss issue-rating: 🦞 diamond lobster maturity:stable P2
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Eynzof/Hermes-CN-Desktop#616 ·
-
ZCode 3.14.3 に対応する Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
supermomonga/zcode-acp#24 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
growthbook/growthbook#7100 ·
-
triage
Difficulty 1/5 1-3 hours Newbie friendliness 88/100