NativeScript/NativeScript

Feature: Allow Android ActionBarItems to be themable...

Open

#9,164 opened on Jan 22, 2021

View on GitHub
 (2 comments) (1 reaction) (0 assignees)TypeScript (23,592 stars) (1,634 forks)batch import
backlogfeaturehelp wanted

Description

At the current point the action bar items are not themable via css because they aren't available to change at runtime. However, a workaround is to use a Spannable String as the title, and then theme that probably using the css value ActionBarItem. See: https://stackoverflow.com/questions/9895472/how-do-i-programmatically-change-actionbar-menuitem-text-colour

Please note: .setTitleCondensed(rawTitle); should be set before setting the .setTitle with the spannable string, so that it works around a bug on Android 4.1 on some phones.

This would be a nice minor feature to add at some point in the future...

Contributor guide

Tech stack
typescriptandroidcss
Domain
mobile
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic understanding of NativeScript themingFamiliarity with Android ActionBarKnowledge of CSS styling in NativeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate how NativeScript handles CSS styling of Android ActionBar items. The issue suggests using Spannable String as a workaround, but the goal is to make ActionBarItem directly themable via CSS. Look at the NativeScript source code for Android UI components, possibly in the `ui` folder. Consider whether a new CSS property like `ActionBarItem` should be added. See also the StackOverflow link for context.