NVIDIAGameWorks/kaolin

Squared euclidean distance in sided_distance()

Open

#404 opened on Jun 18, 2021

View on GitHub
 (1 comment) (0 reactions) (1 assignee)Python (3,849 stars) (517 forks)batch import
documentationgood first issuequestion

Description

Hi,

In kaolin/kaolin/metrics/pointcloud.py it says that the sided_distance() method computes

For every point in p1 find the indices and euclidean distances of the closest point in p2.

However, it seems like the underlying _C.metrics.sided_distance_forward_cuda returns the squared euclidean distance. Can you please clarify this?

Thank you

Contributor guide

Tech stack
pythonpytorch
Domain
machine learningbackend
Issue type
documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PythonPyTorch
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Check the documentation in kaolin/kaolin/metrics/pointcloud.py and the implementation of the CUDA kernel to confirm if the function returns squared euclidean distance or actual distance. If the doc is incorrect, update the docstring to reflect squared distance. If the implementation is incorrect, discuss with maintainers on which to fix.
Squared euclidean distance in sided_distance() · NVIDIAGameWorks/kaolin#404 | Good First Issue