NVIDIAGameWorks/kaolin

Squared euclidean distance in sided_distance()

Open

#404 opened on Jun 18, 2021

View on GitHub
 (1 comment) (0 reactions) (1 assignee)Python (517 forks)batch import
documentationgood first issuequestion

Repository metrics

Stars
 (3,849 stars)
PR merge metrics
 (Avg merge 14h 27m) (6 merged PRs in 30d)

Description

Hi,

In kaolin/kaolin/metrics/pointcloud.py it says that the sided_distance() method computes

For every point in p1 find the indices and euclidean distances of the closest point in p2.

However, it seems like the underlying _C.metrics.sided_distance_forward_cuda returns the squared euclidean distance. Can you please clarify this?

Thank you

Contributor guide

Research direction
Verify the return value of ` C.metrics.sided distance forward cuda` to confirm if it returns squared Euclidean distances. If so, update the docstring in `kaolin/metrics/pointcloud.py` to accurately state 'squared Euclidean distance' or modify the function to return actual Euclidean distances.
Tech stack
pythonpytorch
Domain
machine learning
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonPyTorch
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90