NVC++ doesn't define `__cplusplus` correctly in C++20/C++23 mode, which causes issues with our C++ dialect detection.

Open

#736 opened on Jan 18, 2023 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 2/5
Estimated time: 1-3 hours
Newbie friendliness: 48/100

Issue type: Bug
Clarity: Mostly clear
Activity status: Stale
Tech stack: cpp
Domain: compilers

Research direction

Read include/stdexec/__detail/__config.hpp at lines 18-20, then verify how NVC++ reports __cplusplus in C++20 and C++23 modes. Determine the smallest configuration change that avoids incorrect dialect detection for NVC++, and confirm that the resulting checks distinguish the supported C++ modes correctly.

Written by the indexing model from the issue text.

Description

NVC++ doesn't define __cplusplus correctly for C++20/C++23 mode (it defines it as 201709UL). Currently, we check for C++ dialect using __cplusplus in one of our config headers:

https://github.com/NVIDIA/stdexec/blob/main/include/stdexec/__detail/__config.hpp#L18-20

We should probably remove this check for the time being, or modify it for NVC++.

Dominant language: C++
Stars: 2.4k
Forks: 270
Avg merge: 2d 17h
Merged PRs (30d): 37

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

[Bug] NULL pointer dereference in llm_running_callback (NGZA-AX-LLM #3) Open

Difficulty 1/5 Under an hour Newbie friendliness 90/100

AXERA-TECH/ax-llm#77 · Opened Sep 22, 2026
resume() sends a second HTTP response (400) after a successful resume Open

Difficulty 1/5 Under an hour Newbie friendliness 90/100

games-on-whales/wolf#509 · Opened Sep 21, 2026
pn7160: reader goes permanently deaf — post-read IRQ-low check fails reads that succeeded Open

Difficulty 2/5 1-3 hours Newbie friendliness 74/100

esphome/esphome#19452 · Opened Sep 21, 2026
Eval bug: Ministral-3 tool-calls during reasoning are not processed Open

bug-unconfirmed

Difficulty 2/5 1-3 hours Newbie friendliness 76/100

ggml-org/llama.cpp#29248 · Opened Sep 21, 2026
run_tests.py fails on windows, but running tests individually works Open

Difficulty 2/5 1-3 hours Newbie friendliness 74/100

NVIDIA/cuda-samples#453 · Opened Sep 21, 2026

More C++ issues