inplace_stop_token::request_stop() returns an inverted value

Open

#1,419 opened on Oct 7, 2024 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 1/5
Estimated time: Under an hour
Newbie friendliness: 55/100

Issue type: Bug
Clarity: Clearly specified
Activity status: Stale
Tech stack: cpp
Domain: backend

Research direction

Start in include/stdexec/stop_token.hpp at lines 248-275 and inspect the return logic of stdexec::inplace_stop_source::request_stop(). Confirm that its result matches the specified true/false behavior for making a new stop request versus an already-requested source; done when the implementation returns the documented value.

Written by the indexing model from the issue text.

Description

The specification for a stop-source requires that the request_stop() method returns true if a stop-request was made and false if a stop-request could not be made (e.g. because a stop-request had already been made).

However, the current implementation of stdexec::inplace_stop_source::request_stop() as the result inverted.
It returns false if a stop-request was made and true if a stop-request was not made.

See: https://github.com/NVIDIA/stdexec/blob/519f931ef9d44ca6cc8b2c8a3b3cb760a3523d4f/include/stdexec/stop_token.hpp#L248-L275

Dominant language: C++
Stars: 2.4k
Forks: 270
Avg merge: 2d 16h
Merged PRs (30d): 43

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

Use 4:4:4 for multichannel AVIF and HEIF gain maps Open

Difficulty 2/5 1-3 hours Newbie friendliness 70/100

google/libultrahdr#485 · Opened Sep 24, 2026
Missing tile warnings in TileMap dock display with wrong texture filter Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

godotengine/godot#123776 · Opened Sep 23, 2026
if(cond,a,b) treats any nonzero cond as true in every bngsim backend (ExprTk interpreter, C codegen, SSA), which contradicts docs/reference/expressions.md ('true when > 0.5') and BNG's run_network. A non-boolean condition in (-inf,0) or... Open

bug

Difficulty 1/5 Under an hour Newbie friendliness 60/100

lanl/bngsim#774 · Opened Sep 23, 2026
Delete ament_export_include_directories() and ament_export_libraries() calls Open

good first issue

Difficulty 1/5 Under an hour Newbie friendliness 90/100

ros2/rosbag2#2509 · Opened Sep 23, 2026
Delete ament_export_include_directories() and ament_export_libraries() calls Open

good first issue

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

ros2/common_interfaces#344 · Opened Sep 23, 2026

More C++ issues