trunk/src/nvidia/src/kernel/gpu/ce/arch/pascal/kernel_ce_gp100.c:137: unclear coding ?
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- c
- Domain
- operating-systems
Research direction
Open trunk/src/nvidia/src/kernel/gpu/ce/arch/pascal/kernel_ce_gp100.c at line 137 and review the return expression reported by cppcheck. Confirm the intended precedence of '&' and '?' against the surrounding code, then rerun cppcheck or the relevant checks to verify the warning is resolved.
Written by the indexing model from the issue text.
Description
Static analyser cppcheck says:
src/nvidia/src/kernel/gpu/ce/arch/pascal/kernel_ce_gp100.c:137:53: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
Source code is
return (NVBIT(pKCe->publicID) & nvlinkP2PCeMask ? NV_TRUE : NV_FALSE);
Presumably
return (NVBIT(pKCe->publicID) & nvlinkP2PCeMask) ? NV_TRUE : NV_FALSE;
was intended ?
- Dominant language
- C
- Stars
- 17.4k
- Forks
- 1.9k
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from NVIDIA/open-gpu-kernel-modules
-
build-problem
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
NVIDIA/open-gpu-kernel-modules#1377 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
NVIDIA/open-gpu-kernel-modules#1360 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
NVIDIA/open-gpu-kernel-modules#1343 · 1 comment ·
-
HKC G27H7Pro redundant long-HPD loop after DisplayPort link training (RTX 5060 Laptop, 610.57.04) Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
NVIDIA/open-gpu-kernel-modules#1323 ·
-
build-problem
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
NVIDIA/open-gpu-kernel-modules#1155 · 1 comment ·
All issues in NVIDIA/open-gpu-kernel-modules
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
BasedHardware/omi#15662 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
level/task module/gcp type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
Difficulty 1/5 Under an hour Newbie friendliness 86/100
hapostgres/pg_auto_failover#1190 ·
-
docs
Difficulty 1/5 Under an hour Newbie friendliness 85/100