Bug: sysfs_remove, sysfs_rescan, and sysfs_reset proceed to open() after detecting missing path
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- python
- Domain
- operating-systems
Research direction
Start in pci/device.py at sysfs_remove, sysfs_rescan, and sysfs_reset, and compare their missing-path checks with sysfs_power_control_set, sysfs_unbind, and sysfs_bind. Done means each function returns immediately after logging when its sysfs path does not exist, avoiding the subsequent open() and FileNotFoundError.
Written by the indexing model from the issue text.
Description
Description
Three functions in pci/device.py check whether a sysfs path exists but continue to open() the path even when the check fails. This causes a FileNotFoundError instead of gracefully skipping the operation.
Affected Code
File: pci/device.py
sysfs_remove (lines 449-454):
def sysfs_remove(self):
remove_path = os.path.join(self.dev_path, "remove")
if not os.path.exists(remove_path):
debug("%s remove not present: '%s'", self, remove_path)
# Missing return here — falls through to open()
with open(remove_path, "w") as f:
f.write("1")
sysfs_rescan (lines 456-461): Same pattern — missing return after debug log.
sysfs_reset (lines 493-499): Same pattern — missing return after error log.
Expected Behavior
These functions should return early when the path doesn't exist, matching the pattern used by other functions in the same file:
sysfs_power_control_set(line 444): hasreturnsysfs_unbind(line 467): hasreturnsysfs_bind(line 476): hasreturnsysfs_get_driver(line 484): hasreturn Nonesysfs_get_module(line 490): hasreturn None
Suggested Fix
Add return after the existence check in each of the three functions:
def sysfs_remove(self):
remove_path = os.path.join(self.dev_path, "remove")
if not os.path.exists(remove_path):
debug("%s remove not present: '%s'", self, remove_path)
return # <-- add this
with open(remove_path, "w") as f:
f.write("1")
Same fix for sysfs_rescan and sysfs_reset.
Version
Tag v2025.11.21 (commit 6495b91)
- Dominant language
- Python
- Stars
- 92
- Forks
- 35
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from NVIDIA/gpu-admin-tools
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
NVIDIA/gpu-admin-tools#17 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
NVIDIA/gpu-admin-tools#13 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
NVIDIA/gpu-admin-tools#12 ·
-
RTX 2000 Ada support Open
Difficulty 4/5 3-5 days Newbie friendliness 38/100
NVIDIA/gpu-admin-tools#11 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
NVIDIA/gpu-admin-tools#8 · 3 comments ·
All issues in NVIDIA/gpu-admin-tools
Similar issues
-
documentation help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
simonw/sqlite-utils#872 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100