[Bug]: model registry validator accepts padded names and config IDs

Open Beginner friendly
#17,755 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
python
Domain
backend

Research direction

Start at the validate_models() entry point and inspect the focused validator tests or their surrounding test module. Add regression coverage showing that leading or trailing whitespace in name and config_id is rejected; done means padded identifiers no longer pass validation.

Written by the indexing model from the issue text.

Description

AutoDeploy
System Info

Platform-independent AutoDeploy registry validation.

Reproduction

validate_models() checks name and config_id with .strip() only to determine whether they are non-empty, but then retains the original untrimmed values. Entries such as name: "model" and name: "model ", or config_id: "default" and config_id: " default", therefore pass validation as distinct identifiers.

These invisible leading/trailing characters can bypass duplicate checks and later produce lookup mismatches.

Expected behavior

Registry identifiers should reject leading or trailing whitespace.

Actual behavior

Padded non-empty strings are accepted.

Proposed fix

Reject surrounding whitespace in name and config_id, with focused validator regression tests.

Dominant language
Python
Stars
14.7k
Forks
2.8k
Avg merge
3d 3h
Merged PRs (30d)
493

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from NVIDIA/TensorRT-LLM

All issues in NVIDIA/TensorRT-LLM

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.