[Bug]: Kibana restart handler ignores kibana_enable
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 82/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- ansible
- Domain
- devops
Research direction
Start in roles/kibana/handlers/main.yml and compare the Restart Kibana handler with the corresponding Logstash and Beats handlers. Confirm the behavior when kibana_enable is false and kibana.yml changes; done means the handler no longer attempts a restart while Kibana is disabled.
Written by the indexing model from the issue text.
Description
Please try to fill out as much of the information below as you can. Thank you!
- Yes, I've searched similar issues on GitHub and didn't find any.
Which version contains the bug?
No response
Description
The "Restart Kibana" handler in roles/kibana/handlers/main.yml only checks
not kibana_freshstart.changed. Unlike the logstash and beats restart handlers, it does
not also check kibana_enable.
As a result, if kibana_enable: false (Kibana should not run) but the role still changes
kibana.yml (kibana_manage_yaml is true by default), the config task notifies the
handler and it tries to restart the kibana service anyway — contrary to the user having
disabled it.
Fix
Guard the handler with kibana_enable as well, matching the logstash/beats handlers:
when:
- kibana_enable | bool
- not kibana_freshstart.changed | bool
- Dominant language
- Jinja
- Stars
- 14
- Forks
- 11
- Avg merge
- 1d 47m
- Merged PRs (30d)
- 6
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from NETWAYS/ansible-collection-elasticstack
-
component:beats
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
NETWAYS/ansible-collection-elasticstack#519 · 1 comment ·
-
component:filebeat
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
bug component:elasticsearch
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
breaking-change component:elasticsearch quality
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
component:metricbeat
Difficulty 1/5 Under an hour Newbie friendliness 94/100
All issues in NETWAYS/ansible-collection-elasticstack
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
sympozium-ai/sympozium#627 ·
-
repo:raw-data
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
hotosm/raw-data-api#316 · 1 comment ·
-
agentic-workflows cascade-suspected
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
willow
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
openedx/openedx-authz#460 ·