NCAR/music-box

JavaScript solve() output is missing ENV columns

Open

#451 opened on Apr 15, 2026

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Jupyter Notebook (17 forks)auto 404
good first issue

Repository metrics

Stars
 (37 stars)
PR merge metrics
 (PR metrics pending)

Description

The JavaScript MusicBox.solve() returns only time.s and CONC.* columns. The Python implementation also outputs ENV.temperature.K, ENV.pressure.Pa, and ENV.air number density.mol m-3 by reading them back from the solver state after each step. Any downstream code written against the Python output schema will break when switching to the JavaScript implementation.

Acceptance Criteria

  • JavaScript solve() output includes ENV.temperature.K, ENV.pressure.Pa, and ENV.air number density.mol m-3 columns
  • Column order matches the Python output: time, ENV columns, then CONC columns
  • Parity test confirms the two implementations produce the same column set

Ideas

  • Call state.getConditions() inside appendOutput() alongside the existing state.getConcentrations() call and push the T, P, and air density values into the columns object
  • Check whether getConditions() exists and returns the expected keys in musica 0.15.0 before wiring it up
  • Update the parity test (tests/parity_test.py) to assert column-level equality, not just value-level equality

Contributor guide

Research direction
Inspect the JavaScript solve() function in the music box repository to identify where output columns are generated. Add a call to state.getConditions() inside appendOutput() alongside getConcentrations() to include ENV columns (temperature, pressure, air number density). Ensure column order matches Python: time, ENV, CONC. Update parity test to check column equality.
Tech stack
javascriptpython
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptPythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65