Snow depth variable descriptors are incorrect in GFS_surface_composites*meta

Open Beginner friendly
#969 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
72/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Stale
Domain
documentation

Research direction

Open GFS_surface_composites_post.meta and GFS_surface_composites_pre.meta and inspect the snowd, snowd_lnd, snowd_ice, weasd, and weasd_lnd entries. Compare the descriptors with the issue’s stated physical meanings and update the incorrect standard and long names. Done means both metadata files consistently describe the snow-depth variables correctly; no test is mentioned in the issue.

Written by the indexing model from the issue text.

Description

bug CCPP v7

Description

In GFS_surface_composites_post.meta and GFS_surface_composites_pre.meta the standard name and long name of snowd (and snowd_lnd and snowd_ice) are incorrect.

snowd is the physical snow depth (compare to weasd which is the liquid equivalent snow depth = amount of water in the snow pack)

Both files have:

[snowd]
standard_name = lwe_surface_snow
long_name = water equivalent snow depth

which should be just "snow depth" with no "water equivalent"

Also, the weasd standard name given as:
lwe_thickness_of_surface_snow_amount which is probably correct if lwe stands for "liquid water equivalent"

The weasd_lnd standard_name is water_equivalent_accumulated_snow_depth_over_land which is a better descriptor.

Steps to Reproduce

This is a documentation fix only.

Additional Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

  • Machine
  • Compiler
  • Suite Definition File or Scheme
  • Reference other issues or PRs in other repositories that this is related to, and how they are related.

Output

Please include any relevant log files, screenshots or other output here.

Dominant language
Fortran
Stars
78
Forks
170
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from NCAR/ccpp-physics

All issues in NCAR/ccpp-physics

Similar issues

More Documentation issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.