bug in bnrh_distribution_mod.f90

Open Beginner friendly

#951 opened on Aug 25, 2025 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 2/5
Estimated time: 1-3 hours
Newbie friendliness: 72/100

Issue type: Bug
Clarity: Clearly specified
Activity status: Stale
Tech stack: fortran
Domain: data

Research direction

Start in assimilation_code/modules/assimilation/bnrh_distribution_mod.f90 at lines 509-513 and inspect how this temporary code reports errors elsewhere in the module. Replace the MPI-inappropriate stopping behavior with the established error_handler path, then verify that the repeated final q output no longer leaves MPI tasks inconsistently stopped.

Written by the indexing model from the issue text.

Description

QCEFF

User running r8 = r4,

getting the message:

 final q   0.9999999    
 final q   0.9999999    
 final q   0.9999999 
....

Definite bug that this "temporary" code is calling stop rather then the error_handler (mpi programs only some of the tasks are stopped)
https://github.com/NCAR/DART/blob/55c4b9669f9b65d4b9c315cd5d0f3501fa2b3d22/assimilation_code/modules/assimilation/bnrh_distribution_mod.f90#L509-L513

Dominant language: Fortran
Stars: 263
Forks: 182
Avg merge: 11d 12h
Merged PRs (30d): 7

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

A recording that opens with an all-zero last_throw emits a zeroed discThrown at frame 0 Open

Difficulty 2/5 1-3 hours Newbie friendliness 86/100

EchoTools/tape#60 · Opened Sep 21, 2026
reduce_grouped's backed path rescans the group codes for every group Open

Difficulty 2/5 1-3 hours Newbie friendliness 88/100

scverse/mantispy#113 · Opened Sep 21, 2026
[Bug] Cluster rewrite closes the shared IOManager, breaking later spills of the same write Open

Difficulty 2/5 1-3 hours Newbie friendliness 78/100

apache/paimon#10066 · Opened Sep 21, 2026
videommu: open-ended predictions corrupted by xlsx round-trip, silently zeroed or crash Open

Difficulty 1/5 Under an hour Newbie friendliness 90/100

open-compass/VLMEvalKit#1698 · Opened Sep 21, 2026
Remove deprecated `cfg_if` crate Open

triage:deciding

Difficulty 2/5 1-3 hours Newbie friendliness 68/100

open-telemetry/otel-arrow#4123 · 1 reaction · Opened Sep 21, 2026

More Data Engineering issues