Update AIT-GUI for AIT-Core 3 / msgpack serialization

Open Beginner friendly
#261 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
65/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start at ait/gui/init.py around line 352 and inspect how Plugin.process() handles messages after the AIT-Core 3 msgpack change. Remove the obsolete pickle deserialization and verify that plugins receive the fully recovered message without double deserialization.

Written by the indexing model from the issue text.

Description

As part of https://github.com/NASA-AMMOS/AIT-Core/pull/542, pickle was replaced by msgpack for serialization.

During the pickle era, some messages were double-pickled (pickled prior to passing off the 0MQ where it would be pickled again). Plugin's would eventually receive a pickled-once message, and so would need to call pickle.loads() to recover.
With AIT-Core 3, the message passed to Plugin.process() is fully recovered. So we just need to ensure pickle.loads() is removed.

https://github.com/NASA-AMMOS/AIT-GUI/blob/ac75c7672273418aa1e4f8f560d967086d39c7e3/ait/gui/__init__.py#L352

Dominant language
JavaScript
Stars
31
Forks
15
Avg merge
1m
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from NASA-AMMOS/AIT-GUI

All issues in NASA-AMMOS/AIT-GUI

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.